add solution #140
add solution #140
Conversation
There was a problem hiding this comment.
Great job on implementing the server and HTML form! 🎉 While there are minor issues with the assumption that compressionType and file are arrays, the overall functionality meets the task requirements. Keep up the good work and consider verifying the data structure to enhance robustness in future projects. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| if (req.method === 'POST' && pathname === '/compress') { | ||
| const form = new formidable.IncomingForm(); | ||
|
|
||
| form.parse(req, (error, { compressionType }, { file }) => { |
There was a problem hiding this comment.
The compressionType and file are accessed as arrays (e.g., compressionType[0] and file[0]). Ensure that these variables are indeed arrays. If they are not, you should access them directly without indexing.
| return; | ||
| } | ||
|
|
||
| if (!['gzip', 'deflate', 'br'].includes(compressionType[0])) { |
There was a problem hiding this comment.
The check for compressionType[0] assumes compressionType is an array. Verify that compressionType is an array. If not, adjust the code to handle it correctly.
|
|
||
| res.setHeader( | ||
| 'Content-Disposition', | ||
| `attachment; filename=${file[0].originalFilename}.${compressionType[0]}`, |
There was a problem hiding this comment.
The file[0].originalFilename assumes file is an array. Ensure that file is indeed an array. If not, adjust the code to access the filename correctly.
| `attachment; filename=${file[0].originalFilename}.${compressionType[0]}`, | ||
| ); | ||
|
|
||
| const fileStream = fs.createReadStream(file[0].filepath); |
There was a problem hiding this comment.
The file[0].filepath assumes file is an array. Verify that file is an array. If not, adjust the code to access the filepath correctly.
No description provided.